This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(api): fix Dart API reference page #2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dart API reference page is blank following the merge of angular#2566. This minor fix adjustes to the new API filter criteria. For Dart we don’t show the statuses since none of the API entries are tagged with a status.
chalin
commented
Oct 7, 2016
| @@ -76,7 +76,7 @@ angularIO.directive('apiList', function () { | |||
| { cssClass: 'function', title: 'Function', matches: ['function'] }, | |||
| { cssClass: 'enum', title: 'Enum', matches: ['enum'] }, | |||
| { cssClass: 'type-alias', title: 'Type Alias', matches: ['type-alias'] }, | |||
| { cssClass: 'const', title: 'Const', matches: ['var', 'let', 'const'] } | |||
| { cssClass: 'const', title: 'Const', matches: ['const', 'var', 'let'] } | |||
There was a problem hiding this comment.
This change is necessary so that 'const' elements get picked up in line 215; because 'const' is used as the canonical representative for the matches array elements.
kwalrath
approved these changes
Oct 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart API reference page is blank following the merge of #2566. This minor fix adapts to the new API filter criteria.
Also, for Dart we don’t show the statuses at all since none of the API entries are tagged with a status.
cc @kwalrath @naomiblack @alexwolfe @ericjim